Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Base Button style revisions and final review #32380

Merged
merged 4 commits into from
Apr 29, 2022
Merged

[docs] Base Button style revisions and final review #32380

merged 4 commits into from
Apr 29, 2022

Conversation

samuelsycamore
Copy link
Contributor

This PR reviews the Base ButtonUnstyled document. This one was already in good shape so I just made some minor style and grammar edits throughout.

@samuelsycamore samuelsycamore added package: base-ui Specific to @mui/base docs Improvements or additions to the documentation component: button This is the name of the generic UI component, not the React module! labels Apr 20, 2022
@mui-bot
Copy link

mui-bot commented Apr 20, 2022 •
edited
Loading

Details of bundle changes

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Generated by 🚫 dangerJS against 187c2b3

@samuelsycamore samuelsycamore mentioned this pull request Apr 20, 2022
Closed
20 tasks
@samuelsycamore samuelsycamore requested a review from a team April 21, 2022 16:09
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2022
danilo-leal
danilo-leal approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2022
@samuelsycamore samuelsycamore merged commit 283e3c1 into mui:master Apr 29, 2022
@samuelsycamore samuelsycamore deleted the base-button-style-review branch April 29, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@michaldudak michaldudak michaldudak approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samuelsycamore @mui-bot @mnajdova @michaldudak @danilo-leal