[docs] Base Popper style revisions and final review #32412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelsycamore
added
docs
20 tasks
| By default, the popper is mounted to the DOM when its `open` prop is set to `true` and removed from it when `open` turns `false`. If you want that to happen with a transition, use the `keepMounted` prop (see the [Transition](#transition) example below). | ||
| `anchorEl` is passed as the reference object to create a new `Popper.js` instance. | ||
| The children are placed in a [`Portal`](/base/react-portal/) prepended to the body of the document to avoid rendering problems. | ||
| You can disable this behavior with `disablePortal` prop. | ||
|
|
||
| {{"demo": "SimplePopper.js"}} |
There was a problem hiding this comment.
Hi @samuelsycamore , I was going through the docs on the main website and noticed that in the SimplePopper demo, the popper is not visible in dark mode - https://mui.com/base/react-popper/#basic-popper.
I think we need to simply remove the backgroundColor: '#fff' style applied in the child div for it to work in both modes. In dark mode, the background overlaps with the white text.
Found this PR, so commenting here. It can probably be fixed in this PR.
Preview: https://deploy-preview-32412--material-ui.netlify.app/base/react-popper/#basic-popper
There was a problem hiding this comment.
@ZeeshanTamboli nice catch! I think we can open a dedicated PR for this, as this PR is mostly focused on the copy writing.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reviews the Base
PopperUnstyleddocument. The current version is mostly copypasta from the Material UI doc, so I did a fair bit of rewriting to make it a proper standalone piece. The "Features" section felt more like a list of random details, so I reworked it and dispersed those details throughout the doc.The earlier version mentions transitions and links to a section that doesn't exist—looks like this was pulled directly from the Material UI doc. So I grabbed the text about transitions from that piece and added it here. I'm thinking we should probably add a Base version of the corresponding demo as well.