Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Remove default social card #32536

Merged
merged 2 commits into from
May 10, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 1, 2022

Put #32257 (comment) in motion. See how it feels better, more focus on the content of the tweet, no useless generic text message "The React UI library you always wanted" makes no sense to me in the context of a tweet 😌:

With a custom social image

Same as before: great, no distraction from the content of the tweet, only an illustration to make the tweet more appealing:

Screenshot 2022-05-01 at 16 22 38

Without a custom social image

Before: bad, the text of the image moves the attention away from the important message of the Tweet.

Screenshot 2022-05-01 at 16 41 38

https://mui.com/blog/callback-support-in-style-overrides/

After: not great, but not bad either.

Screenshot 2022-05-01 at 16 43 34

https://deploy-preview-32536--material-ui.netlify.app/blog/callback-support-in-style-overrides/

Related to #32036

@mui-bot
Copy link

mui-bot commented May 1, 2022

No bundle size changes

Generated by 🚫 dangerJS against 7f12b4b

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I might try to add a social card preview for all blog posts we have retroactively at some point :) But this works well for now!

@oliviertassinari
Copy link
Member Author

oliviertassinari commented May 7, 2022

The only counter-argument to this change I can think of this option C would work better:

Option C: create a generic visual for the blog posts. Something with no text to distract the attention. The advantage would be that we would still use a lot of screen real-estate with our blog post tweet.

Maybe it's an option that @samuelsycamore would prefer 🤷‍♂️. I'm happy either. This advantage of this PR (Option B), is that it's less work, and gives us an extra incentive to add a personalized visual to each blog post. I might like B better than C (Option A is current state on master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants