Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Move, split, and revise "Unstyled components" page #32562

Merged
merged 32 commits into from
May 9, 2022
Merged

[docs] Move, split, and revise "Unstyled components" page #32562

merged 32 commits into from
May 9, 2022

Conversation

samuelsycamore
Copy link
Contributor

@samuelsycamore samuelsycamore commented May 2, 2022

Following up on #32072, this PR moves the "Unstyled components" page from the Material UI to the Base docs.

From there, I've split the content up into three two new pages:

  • Anatomy Usage
  • Components vs. hooks
  • Styling Customization

Content on these pages has been updated with additional info, and revised to work better as standalone docs.

@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels May 2, 2022
@mui-bot
Copy link

mui-bot commented May 2, 2022

No bundle size changes

Generated by 🚫 dangerJS against 184876d

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome, way better! Just left a few fine-tuning suggestions :)

docs/data/base/getting-started/usage/usage.md Outdated Show resolved Hide resolved
docs/data/base/getting-started/usage/usage.md Outdated Show resolved Hide resolved
docs/data/base/getting-started/usage/usage.md Show resolved Hide resolved
Sam Sycamore and others added 2 commits May 3, 2022 18:33
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

samuelsycamore and others added 2 commits May 4, 2022 17:31
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
samuelsycamore and others added 2 commits May 5, 2022 10:41
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@samuelsycamore samuelsycamore merged commit 56ca17e into mui:master May 9, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented May 21, 2022

It's great to have this change in, but we forgot to:

  1. add a redirection for the moved page.
  2. update the links that point to https://mui.com/material-ui/customization/unstyled-components/

I have taken care of it in a batch of fixes in #32851. We might want to create a checklist when moving pages so we don't miss it. I think that it's important for the DX. I have seen the same things happen multiple times in a row in MUI X.

@samuelsycamore samuelsycamore deleted the move-unstyled-components-page branch April 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants