Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete component in omitted TablePagination props #32998

Closed
wants to merge 1 commit into from

Conversation

westoncolemanl
Copy link

@westoncolemanl westoncolemanl commented Jun 2, 2022

  1. Without the component ='div' property, TablePagination component does not stretch to the full width of the table.
  2. Instead of writing component ='div' each time we call TablePagination, we set it in our default ThemeOptions
  3. The deleted code prevents us from adding component as a prop to our default ThemeOptions

1. Without the `component ='div'` property, TablePagination component does not stretch to the full width of the table.
2. Instead of writing `component ='div'` each time we call TablePagination, we set it in our default ThemeOptions
3. The deleted code prevents us from adding `component` as a prop to our default ThemeOptions
@mui-bot
Copy link

mui-bot commented Jun 2, 2022

No bundle size changes

Generated by 🚫 dangerJS against 29e3b75

@mnajdova
Copy link
Member

mnajdova commented Jun 8, 2022

Please see #29942, there is a workaround there as an example for the LinkProps. It is not specific to just this component.


I've closed as we can track the problem on the other issue and update the docs accordingly

@mnajdova mnajdova closed this Jun 8, 2022
@zannager zannager added the component: TablePagination The React component. label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: TablePagination The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants