Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add permanent notifications back #33843

Merged
merged 1 commit into from
Aug 11, 2022
Merged

[docs] Add permanent notifications back #33843

merged 1 commit into from
Aug 11, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 7, 2022 •
edited
Loading

A continuation of #33745

  • Remove company category blog posts. I feel that it's off-topic for the docs. AFAIK the purpose of this blog is for curious candidates that browse https://mui.com/blog/?tags=Company.
  • Add the notification about how to get notifications back. I have also mentioned the blog.
  • Welcome Chinese with notification only for them to signal that we want to translate.

Screenshot 2022-08-07 at 21 12 49

Preview: https://deploy-preview-33843--material-ui.netlify.app/material-ui/getting-started/overview/

@oliviertassinari oliviertassinari marked this pull request as ready for review August 7, 2022 18:45
@mui-bot
Copy link

mui-bot commented Aug 7, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against fa7a198

@oliviertassinari oliviertassinari force-pushed the fix-notification-regression branch 3 times, most recently from a6f9de0 to 717fa1f Compare August 7, 2022 19:02
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 7, 2022
@oliviertassinari oliviertassinari mentioned this pull request Aug 7, 2022
Merged
@oliviertassinari oliviertassinari merged commit 7587a42 into mui:master Aug 11, 2022
@oliviertassinari oliviertassinari deleted the fix-notification-regression branch August 11, 2022 17:01
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@oliviertassinari
[docs] Add permanent notifications back (mui#33843)
50c6ca1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @samuelsycamore