[system] Show type error for invalid properties in sx prop #33879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
bug 🐛
|
Overall I would be leaning toward making the types less complicated instead, as this type is currently one of the bottlenecks we have in #19113. Not saying the fix is not good, just that it may hurt perf even more. I would rather first spend some time trying to simplify it. |
|
Closing this as we want to simplify the types first as suggested above. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33794
Detailed explanation in #33794 (comment).
I believe this is not a robust solution. I opened this PR to discuss if there's a better solution.
Before: https://codesandbox.io/s/jovial-glitter-kt9uvc?file=/demo.tsx
After: https://codesandbox.io/s/agitated-brattain-3dv74i?file=/demo.tsx
Works for me with TypeScript version 3.5.3