-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Toolbar] toolbar-title overflow: Set width in the example #3463
Conversation
Giving users the power to fix it seems better 👍. Can we remove the magic width value now? |
@oliviertassinari : Which magic width are you referring to? I have removed it from The width value of |
Sorry I was confused not seeing this line removed https://github.com/callemall/material-ui/pull/3250/files#diff-6ac27b5e67882578a46d38f690fd414bR20. Could you rebase 👍? |
76115b6
to
965e5a4
Compare
@oliviertassinari : Done. |
@@ -37,7 +37,7 @@ export default class ToolbarExamplesSimple extends React.Component { | |||
</DropDownMenu> | |||
</ToolbarGroup> | |||
<ToolbarGroup float="right"> | |||
<ToolbarTitle text="Options" /> | |||
<ToolbarTitle text="Options" style={{width: 150}} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
90
would be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing it to 90
965e5a4
to
131789d
Compare
131789d
to
db8cd8d
Compare
[Toolbar] toolbar-title overflow: Set width in the example
This references issue: #3192
Previously submitted PR: #3250
toolbar-title.jsx
remains the same except for the width attribute.width:150px
based on the implementation in the example page but I understand that it is still a magic constant and my suggestion would be to add a note in the docs mentioning the same like its done for the popover ghost touch issue , as it is more of an implementation issue.P.S: I created a new branch and proceeded the issue in a fresh manner hence the new branch.