Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input][base] Drop component prop #37057

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Apr 27, 2023

No description provided.

@mui-bot
Copy link

mui-bot commented Apr 27, 2023

Netlify deploy preview

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 6f25164

@zannager zannager requested a review from mnajdova April 27, 2023 13:35
@hbjORbj hbjORbj requested review from michaldudak and removed request for mnajdova April 28, 2023 09:19

```jsx
<Input slots={{ root: 'aside' }} />
<Input slots={{ root: 'aside', input: 'button' }} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input: 'button' likely won't work well (and it doesn't have sense).

Suggested change
<Input slots={{ root: 'aside', input: 'button' }} />
<Input slots={{ root: 'aside', input: CustomInput }} />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@hbjORbj hbjORbj enabled auto-merge (squash) April 28, 2023 13:36
@hbjORbj hbjORbj disabled auto-merge April 28, 2023 13:58
@hbjORbj hbjORbj merged commit 4a28f00 into mui:master Apr 28, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants