-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MenuItem][Joy] Add internal id to DOM #37361
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
Something doesn't work
component: menu
This is the name of the generic UI component, not the React module!
design: joy
This is about Joy Design, please involve a visual or UX designer in the process
labels
May 22, 2023
Netlify deploy previewhttps://deploy-preview-37361--material-ui.netlify.app/ Bundle size report |
sai6855
added
package: joy-ui
Specific to @mui/joy
and removed
design: joy
This is about Joy Design, please involve a visual or UX designer in the process
labels
May 22, 2023
sai6855
commented
May 22, 2023
@@ -184,6 +184,20 @@ describe('Joy <MenuItem />', () => { | |||
expect(menuitem).to.have.attribute('aria-disabled', 'true'); | |||
}); | |||
|
|||
it('should add external id to DOM and override internal id', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is passing in master too but i just wanted to add a test which tests adding extrenal id to DOM when available
sai6855
changed the title
[MenuItem][Joy] Accept external id
[MenuItem][Joy] Accept internal id to DOM
May 22, 2023
sai6855
changed the title
[MenuItem][Joy] Accept internal id to DOM
[MenuItem][Joy] Add internal id to DOM
May 22, 2023
closing in favour of #37364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: menu
This is the name of the generic UI component, not the React module!
package: joy-ui
Specific to @mui/joy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspect
first
option of both sandboxes and you can seeid
is added to dom only inafter
sandboxbefore: https://codesandbox.io/s/quirky-chaplygin-5skfj3?file=/demo.tsx
after: https://codesandbox.io/s/nervous-pond-l5cfzp?file=/demo.tsx
This PR fixes
adding internal
id
toMenuItem
DOM when externalid
is not providedovverding internal
id
inuseMenuItem
hook (code change) when externalid
is providedI have followed (at least) the PR section of the contributing guide.