Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Refactor IntersectionObserver logic #38133

Merged
merged 4 commits into from
Jul 25, 2023
Merged

[Tabs] Refactor IntersectionObserver logic #38133

merged 4 commits into from
Jul 25, 2023

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jul 24, 2023 •
edited
Loading

Noticed in #36071.

@ZeeshanTamboli ZeeshanTamboli added component: tabs This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Jul 24, 2023
@mui-bot
Copy link

mui-bot commented Jul 24, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38133--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 936680e

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review July 24, 2023 09:07
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Jul 24, 2023
Merged
1 task
@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes and removed enhancement This is not a bug, nor a new feature labels Jul 24, 2023
oliviertassinari
oliviertassinari approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I also like the idea to not change logic and tests at the same time.

@ZeeshanTamboli ZeeshanTamboli merged commit 2e56fbd into mui:master Jul 25, 2023
7 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the refactor-tabs-intersection-observer-logic branch July 25, 2023 06:16
@oliviertassinari oliviertassinari mentioned this pull request Nov 22, 2023
Open
@kealjones-wk kealjones-wk mentioned this pull request Jan 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeeshanTamboli @mui-bot @oliviertassinari