Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReactNative] Add support for the Subheader component #3829

Closed
wants to merge 1 commit into from
Closed

[ReactNative] Add support for the Subheader component #3829

wants to merge 1 commit into from

Conversation

oliviertassinari
Copy link
Member

The react native effort has started a long time ago. This PR is introducing a native version of the Subheader. It's a proof of concept.

The component is located under the Subheader folder and called Subheader.native.js.
We should probably add a filter to remove the .native.js files from the material-ui npm package.

I'm using:

Demo

capture d ecran 2016-03-28 a 20 47 47

@oliviertassinari oliviertassinari added React Native PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 28, 2016
@oliviertassinari oliviertassinari changed the title [ReactNative] Add support [ReactNative] Add support for the Subheader component Mar 28, 2016
@oliviertassinari oliviertassinari added PR: Needs Review and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 28, 2016
@oliviertassinari oliviertassinari mentioned this pull request Apr 2, 2016
Closed
@oliviertassinari oliviertassinari mentioned this pull request Jun 2, 2016
Open
@oliviertassinari oliviertassinari mentioned this pull request Jun 26, 2016
Closed
@oliviertassinari oliviertassinari added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 16, 2016
@oliviertassinari
Copy link
Member Author

I'm closing this issue as the react-native branch isn't quite ready to be merged into master.
I'm not really happy with the current solution where we would have to duplicate most of our code between the two platforms.

@oliviertassinari oliviertassinari deleted the react-native branch October 8, 2016 11:09
@oliviertassinari oliviertassinari restored the react-native branch October 8, 2016 11:10
@oliviertassinari oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 8, 2016
@muibot muibot added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Oct 8, 2016
@oliviertassinari oliviertassinari deleted the react-native branch January 6, 2017 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @muibot