Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Select] Fix MenuProps slotProps forwarding #39177

Merged
merged 2 commits into from
Sep 27, 2023
Merged

[material-ui][Select] Fix MenuProps slotProps forwarding #39177

merged 2 commits into from
Sep 27, 2023

Conversation

DiegoAndai
Copy link
Member

Fixes: #38949

Required changes to fix the issue:

  • Forward missing slotProps keys from Select's MenuProps to Menu. Only the paper key was passed to the Menu so the root one was missing.
  • The Menu's slots and slotProps type should be the same as the Popover, as they're forwarded.

@DiegoAndai DiegoAndai added component: select This is the name of the generic UI component, not the React module! typescript regression A bug, but worse labels Sep 26, 2023
@DiegoAndai DiegoAndai self-assigned this Sep 26, 2023
@DiegoAndai DiegoAndai changed the title [material-ui][Select] Fix slotProps forwarding [material-ui][Select] Fix MenuProps slotProps forwarding Sep 26, 2023
@DiegoAndai DiegoAndai added component: menu This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Sep 26, 2023
@mui-bot
Copy link

mui-bot commented Sep 26, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39177--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 2e91295

michaldudak
michaldudak approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ZeeshanTamboli
ZeeshanTamboli approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DiegoAndai DiegoAndai merged commit 99a1b85 into mui:master Sep 27, 2023
24 checks passed
@DiegoAndai DiegoAndai deleted the fix-select-backdrop-slot branch September 27, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees

@DiegoAndai DiegoAndai

Labels
component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] slotProps can't pass to backdrop component
4 participants
@DiegoAndai @mui-bot @michaldudak @ZeeshanTamboli