Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][Templates] Update and standardize Sidemenus #39271

Merged
merged 4 commits into from
Oct 3, 2023
Merged

[joy-ui][Templates] Update and standardize Sidemenus #39271

merged 4 commits into from
Oct 3, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Oct 2, 2023 •
edited by danilo-leal
Loading

@zanivan zanivan added package: joy-ui Specific to @mui/joy design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Oct 2, 2023
@zanivan zanivan added this to the Joy UI: Stable release milestone Oct 2, 2023
@zanivan zanivan self-assigned this Oct 2, 2023
@mui-bot
Copy link

mui-bot commented Oct 2, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39271--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 06234b5

@danilo-leal danilo-leal mentioned this pull request Oct 2, 2023
Closed
10 tasks
@danilo-leal danilo-leal removed this from the Joy UI: Stable release milestone Oct 2, 2023
danilo-leal
danilo-leal approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for picking this one up — love the attention to detail! 💪
Just left a small nit comment there.

docs/data/joy/getting-started/templates/order-dashboard/components/Sidebar.tsx Outdated Show resolved Hide resolved
@zanivan zanivan merged commit 62d3b96 into mui:master Oct 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees

@zanivan zanivan

Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process package: joy-ui Specific to @mui/joy
Projects
Joy UI
Status: Recently completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanivan @mui-bot @danilo-leal