Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material][tab] Show/hide scroll buttons for dynamically added children #39415

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Oct 12, 2023

Closes #39394

Before:

Screen.Recording.2023-10-12.at.6.52.05.PM.mov

After:

https://deploy-preview-39415--material-ui.netlify.app/material-ui/react-tabs/#dynamically-added-tabs

@mui-bot
Copy link

mui-bot commented Oct 12, 2023

Netlify deploy preview

https://deploy-preview-39415--material-ui.netlify.app/

@material-ui/core: parsed: +0.06% , gzip: +0.07%
@material-ui/lab: parsed: +0.12% , gzip: +0.12%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against f2a59f4

@brijeshb42 brijeshb42 added bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Oct 12, 2023
@CarlosAmaral
Copy link

I'm happy this has been fixed, thanks a lot! Looking forward to the release of this bugfix.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean! 👌 If it is up to me, I would remove the demo, this is a bug fix, not a new feature worth documenting in my opinion.

docs/data/material/components/tabs/tabs.md Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member

I have reopened #39394, we missed a regression test, and we can likely simplify the fix #39394 (comment).

@brijeshb42 brijeshb42 deleted the fix-39394 branch November 23, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
5 participants