[docs] Fix Next.js v13.5.1 <title> SEO regression #40302
Conversation
oliviertassinari
added
docs
oliviertassinari
force-pushed
the
upgrade-next-js
branch
from
633e785
to
406c7f3
Compare
Netlify deploy previewhttps://deploy-preview-40302--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
upgrade-next-js
branch
from
406c7f3
to
dcca619
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
force-pushed
the
upgrade-next-js
branch
from
dcca619
to
91582bd
Compare
oliviertassinari
added
bug 🐛
oliviertassinari
changed the title
|
Rebased on HEAD |
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
|
Problem looks solved:
|
|
It looks like Netlify builds are failing 40% of the time on HEAD since we merged this PR. https://app.netlify.com/sites/material-ui/deploys?filter=master labels the origin pretty clearly to be here. I think we need to either revert #40302 and #40423 or fix it. Is this what #41111 tries to do? Unfortunately, it's not helping. Strange as this doesn't happen on MUI X. |
|
@Janpot found a failing build prior to this change: https://app.netlify.com/sites/material-ui/deploys/65c3bb5ccb8fee00087cbe74 We're trying different approaches to handle this and you can see our attempts among PRs. |
And this is what led me to believe it could've been connected to the next.config.mjs change that was merged earlier that day. Sadly reverting back to next.config.js did produce a failing build as well. The change right before that is the Next.js update. We could indeed try reverting to 13.4.19. update: nope, reverting Next.js produced a failing build Otherwise I guess we could start bissecting and open a PR that reverts to a specific commit, and go backwards until we can't reproduce anymore. Or until we can safely state it's a platform issue on latest netlify images.
I'm stopping this effort unless #41132 turns out not to fix it |
| "build:clean": "rimraf .next && pnpm build", | ||
| "build-sw": "node ./scripts/buildServiceWorker.js", | ||
| "dev": "next dev", | ||
| "deploy": "git push -f material-ui-docs master:latest", | ||
| "export": "rimraf docs/export && next export --threads=3 -o export && pnpm build-sw", |
There was a problem hiding this comment.
@oliviertassinari Any idea what caused us to add this --threads=3? It doesn't seem to translate anywhere in the output: 'export' setup.
edit: got it, netlify resource issues it seems
edit 2: checked the next.js source code and it seems that option is now coming from experimental.cpus.
Fix the SEO regression introduced from #40423
Use the same fix as in mui/mui-x#11182.
Preview: https://deploy-preview-40302--material-ui.netlify.app/