Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Revise the Divider page #40356

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Dec 29, 2023

This PR is a general formatting, editing, and demo simplification revision of the Material UI Divider page. I've removed a couple of demos that I felt weren't necessarily adding a lot and were a bit more list-related than anything else. This PR also hopefully closes #34248, which was the motivation for it in the first place when I found it earlier today! It felt like a reasonably quick win. :)

https://deploy-preview-40356--material-ui.netlify.app/material-ui/react-divider/

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: divider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Dec 29, 2023
@danilo-leal danilo-leal self-assigned this Dec 29, 2023
@mui-bot
Copy link

mui-bot commented Dec 29, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d836008

docs/data/material/components/dividers/dividers.md Outdated Show resolved Hide resolved
docs/data/material/components/dividers/dividers.md Outdated Show resolved Hide resolved
docs/data/material/components/dividers/dividers.md Outdated Show resolved Hide resolved
docs/data/material/components/dividers/dividers.md Outdated Show resolved Hide resolved
docs/data/material/components/dividers/dividers.md Outdated Show resolved Hide resolved
docs/data/material/components/dividers/dividers.md Outdated Show resolved Hide resolved
docs/data/material/components/dividers/dividers.md Outdated Show resolved Hide resolved
Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentatively approving because I'm really just nitpicking at this point 😁 nice job!

docs/data/material/components/dividers/dividers.md Outdated Show resolved Hide resolved
@danilo-leal danilo-leal merged commit a473383 into mui:master Jan 2, 2024
19 checks passed
@danilo-leal danilo-leal deleted the revise-divider-page branch January 2, 2024 15:11
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: divider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Divider] Component is announced by screen readers
3 participants