[code-infra] Migrate to prettier async APIs #40668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40668--material-ui.netlify.app/ Bundle size report |
Janpot
commented
Jan 18, 2024
| { | ||
| files: ['**/*.json'], | ||
| options: { | ||
| trailingComma: 'none', |
There was a problem hiding this comment.
This seems to be needed in upcoming major of prettier. I'm already adding it
Janpot
requested review from
siriwatknp,
michaldudak and
mnajdova
as code owners
michaldudak
approved these changes
Jan 18, 2024
|
blocked on mui/mui-x#11734 which in turn is blocked on mui/mui-x#11671 |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync APIs are deprecated in upcoming major.
Pushing these changes without bumping the major to avoid cluttering it with all the formatting changes.
Haven't deeply investigated, but it looks like there are more opportunities for parallelization in these scripts. I also noticed a few sync IO calls.