-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Speed up the envinfo test #40669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40669--material-ui.netlify.app/ Bundle size report |
michaldudak
force-pushed
the
speed-up-envinfo-test
branch
from
January 18, 2024 09:57
0e8bc9d
to
6851c5c
Compare
github-actions
bot
added
PR: out-of-date
The pull request has merge conflicts and can't be merged
and removed
PR: out-of-date
The pull request has merge conflicts and can't be merged
labels
Jan 19, 2024
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jan 28, 2024
michaldudak
force-pushed
the
speed-up-envinfo-test
branch
from
January 29, 2024 15:28
a7dd74b
to
22ef9c4
Compare
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jan 29, 2024
Janpot
approved these changes
Jan 29, 2024
oliviertassinari
changed the title
[envinfo] Speed up the envinfo test
[test] Speed up the envinfo test
Jan 29, 2024
Both, actually. A simpler way to improve flakiness would be to increase the timeout, but given the low risk associated with this test, I ended up reimplemienting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up the envinfo package test that often times out:
npx
, the script is tested by executing it directly withnode
. This slightly increases the potential for errors, but given that the package is hardly ever updated, it's a risk we can accept.