-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Update prettier #40772
[code-infra] Update prettier #40772
Conversation
Netlify deploy previewBundle size report |
I have this issue where if I run
and then
I get a bunch of typescript errors around joy UI. No problem if I skip running
@siriwatknp @michaldudak I have a hunch there's some implicit dependency issue around |
It seems that csstype 3.1.3 has breaking changes (frenic/csstype#189). Pinning the version to 3.1.2 prevents these issues from happening. I'll see if it could be fixed on our side. |
Pinning it to 3.1.2 in the resolutions didn't seem to help. Adding it to |
Pinning in resolutions does help in Joy only. |
Found it. This fixes the issue, here is the PR. diff --git a/packages/mui-system/src/styleFunctionSx/styleFunctionSx.d.ts b/packages/mui-system/src/styleFunctionSx/styleFunctionSx.d.ts
index 929177b4cd..6d373d0ae5 100644
--- a/packages/mui-system/src/styleFunctionSx/styleFunctionSx.d.ts
+++ b/packages/mui-system/src/styleFunctionSx/styleFunctionSx.d.ts
@@ -9,7 +9,7 @@ import { OverwriteCSSProperties } from './OverwriteCSSProperties';
* Note that this extends to non-theme values also. For example `display=['none', 'block']`
* will also works.
*/
-export type ResponsiveStyleValue<T> = T | Array<T | null> | { [key: string]: T | null };
+export type ResponsiveStyleValue<T> = T | ReadonlyArray<T | null> | { [key: string]: T | null };
/**
* Map of all CSS pseudo selectors (`:hover`, `:focus`, ...).
|
I pushed the a900b56 to test if it works in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lowercase doctype
seems controversial (prettier/prettier#7391) but I really like indented ternaries.
The result of running