-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Select] Fix to show notched outline when displayEmpty
#40865
[material-ui][Select] Fix to show notched outline when displayEmpty
#40865
Conversation
Netlify deploy previewhttps://deploy-preview-40865--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Thanks for the PR! The sandboxes you linked seem to be missing. Could you take a look? |
Somehow it was set as private. I changed it to public now. Are you able to see it now? Looks like sandboxes will be private in future. |
Not related to my changes. The CodeSandboxes had different styles. The "After" one had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks fine to me. However, the before/after sandboxes still differ. Ideally, they should use the same sources and only reference different packages.
Agreed. I've kept them the same now and referenced different packages. I updated the links in the description. |
Fixes #27533 specifically #27533 (comment) and #27533 (comment).
The outlined input should have a notch when displaying an empty value using the displayEmpty prop, even if the select isn't focused.
Before: https://codesandbox.io/p/sandbox/material-ui-outlined-select-label-is-not-rendering-properly-forked-8q5kwv?file=%2Fsrc%2FApp.js%3A25%2C18
After: https://codesandbox.io/p/sandbox/material-ui-outlined-select-label-is-not-rendering-properly-forked-q69vh7?file=%2Fpackage.json%3A12%2C34