Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Select] Fix to show notched outline when displayEmpty #40865

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jan 31, 2024

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jan 31, 2024
@mui-bot
Copy link

mui-bot commented Jan 31, 2024

Netlify deploy preview

https://deploy-preview-40865--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 2a49efd

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review January 31, 2024 05:53
@michaldudak
Copy link
Member

Thanks for the PR! The sandboxes you linked seem to be missing. Could you take a look?

@ZeeshanTamboli
Copy link
Member Author

Thanks for the PR! The sandboxes you linked seem to be missing. Could you take a look?

Somehow it was set as private. I changed it to public now. Are you able to see it now? Looks like sandboxes will be private in future.

@michaldudak
Copy link
Member

michaldudak commented Jan 31, 2024

Yes, it's OK now, thanks!

Is the difference in margins related to your changes or are there different styles in these sandboxes?

image image

@ZeeshanTamboli
Copy link
Member Author

ZeeshanTamboli commented Jan 31, 2024

Is the difference in margins related to your changes or are there different styles in these sandboxes?

Not related to my changes. The CodeSandboxes had different styles. The "After" one had CssBaseline, hence the margin. I updated the link for the "After" CodeSandbox. You can check again.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks fine to me. However, the before/after sandboxes still differ. Ideally, they should use the same sources and only reference different packages.

@ZeeshanTamboli
Copy link
Member Author

However, the before/after sandboxes still differ. Ideally, they should use the same sources and only reference different packages.

Agreed. I've kept them the same now and referenced different packages. I updated the links in the description.

@ZeeshanTamboli ZeeshanTamboli merged commit 1c13e7e into mui:master Jan 31, 2024
19 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the fix-27533-select-outlined-input-label-strikethrough branch January 31, 2024 09:55
mostafa-rio pushed a commit to mostafa-rio/material-ui that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] Outlined component's label has no background fill (looks "strikethrough")
3 participants