Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Box] Add basic demo to Box #40982

Closed
wants to merge 3 commits into from

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Feb 7, 2024

This PR aims to add a basic demo to the Box component. Even though it's a MUI System component, I believe we could have at least one simple demos for it, since we re-export this component from mui/material.

I also changed the warning callout for an introduction text. I believe this way the link to Box on MUI System docs will stand out more.

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material component: Box The React component. labels Feb 7, 2024
@zanivan zanivan self-assigned this Feb 7, 2024
@mui-bot
Copy link

mui-bot commented Feb 7, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c02bea5

@danilo-leal
Copy link
Contributor

Little note here just to make sure this is coordinated with @samuelsycamore's PR about restoring and adding content back to the Box page: #40622

@zanivan
Copy link
Contributor Author

zanivan commented Feb 7, 2024

Little note here just to make sure this is coordinated with @samuelsycamore's PR about restoring and adding content back to the Box page: #40622

Oh nice! I thought this tiny tweak could be something good to have merged for now, until we wait for the major revamp of this page. @samuelsycamore let me know what you think, and tell me if you need any help with this :)

@samuelsycamore
Copy link
Member

I got caught up in other projects and wasn't able to finish #40622 as quickly as I'd hoped to. 😅 I could pick it back up and probably finish out the content this week—I do think we should just duplicate this doc in its entirety across all of the relevant products, because it's too confusing for many users otherwise. But @zanivan I would love your help revamping the demos if you have ideas! I could tag you in on that revision PR once I'm done with my edits and have you push to that same branch so we can get it done without stepping on each others' toes too much.

@zanivan
Copy link
Contributor Author

zanivan commented Feb 7, 2024

I do think we should just duplicate this doc in its entirety across all of the relevant products

100% agreed!

I could tag you in on that revision PR once I'm done with my edits and have you push to that same branch so we can get it done without stepping on each others' toes too much.

Sure thing! Feel free to ping me when it's ready, I'd love to help with that :)


Closing this to centralize the work on #40622

@zanivan zanivan closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Box The React component. docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants