-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Move typescript-to-proptypes to internal-scripts package #41079
Conversation
Netlify deploy previewhttps://deploy-preview-41079--material-ui.netlify.app/ Bundle size report |
pnpm-workspace.yaml
Outdated
@@ -5,3 +5,4 @@ packages: | |||
- 'docs' | |||
- 'test' | |||
- 'apps/*' | |||
- 'internal/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where we will collect al internal packages? i.e. all @mui/internal-
packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the idea. This could also be named internal-packages
if you like, but internal
matches the package prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 got it.
Up to you, I don't have a strong opinion on this. I we end up renaming it, I'd be more leaning towards packages-internal
as that will place it next to the packages
folder in the file explorer.
99dcea9
to
01931c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be more inclined towards packages-internal
, but at your own discretion
I don't have a strong preference, so let it be |
0fd8ae0
to
299402d
Compare
MUI X integration: mui/mui-x#12142 |
Created the @mui/internal-scripts package with its first subpackage: typescript-to-proptypes.