[docs-infra] Fix external link arrow #41181
Conversation
Netlify deploy previewBundle size report |
| // Allows to remove link arrows for images | ||
| display: 'none', | ||
| }, | ||
| '& a[href*="carbonads"][target="_blank"]::after': { |
There was a problem hiding this comment.
It can be more than carbon ads, I think we need a more generic selectors.
There was a problem hiding this comment.
What about targeting links inside those 3 selectors:
document.querySelector('.ea-placement')
document.querySelector('#carbonads')
document.querySelector('.carbonads')
https://github.com/mui/material-ui/blob/master/docs/src/modules/components/Ad.js/#L157-L160
There was a problem hiding this comment.
Instead, Could we create/add a new class name to an existing DOM node around the ad?
It would make it less brittle to future changes. For example, what if we implement: https://www.notion.so/mui-org/docs-infra-Ad-networks-fcd294a093354a94a329ab9852433fdc?pvs=4#ee1fd00fd3b642f28439c7d1f211695f?
There was a problem hiding this comment.
Do you know what is .ea-placement for? The search in codebase returns 0 files with this text 🤔
Could it be an old elements that does not exist anymmore?
There was a problem hiding this comment.
Do you know what is .ea-placement for?
ea was for EthicalAds
Style spread on two different files will be hard to keep in sync. Follow-up on #41181 Also simplify the CSS selector for performance.
Style spread on two different files will be hard to keep in sync. Follow-up on mui#41181 Also simplify the CSS selector for performance.
Fix #41129 (comment)
hrefattibutes. if it containscabonadsI remove the arrowdocs/data/**/*.mdthat contains_blankSo I added a class by hand to them