-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Split Toolpad documentation #41316
Conversation
Netlify deploy previewhttps://deploy-preview-41316--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you're waiting for something, but it looks good to me!
@@ -15,7 +15,7 @@ swap: | |||
MUI System: MUI System | |||
MUI Store: MUI Store | |||
MUI Core: MUI Core | |||
MUI Toolpad: MUI Toolpad | |||
Toolpad: Toolpad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toolpad: Toolpad | |
MUI Toolpad: Toolpad | |
MUI Toolpad: Toolpad |
handled in #41516.
if (firstFolder === 'toolpad') { | ||
productCategoryId = 'toolpad'; | ||
const secondFolder = asPathWithoutLang.replace(/^\/+[^/]+\/([^/]+)\/.*/, '$1'); | ||
if (secondFolder === 'studio') { | ||
productId = 'toolpad-studio'; | ||
} else { | ||
productId = 'toolpad-core'; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharatkashyap Can we fix MuiProductId
and MuiProductCategoryId
? These types are wrong now. Thanks
Add productIds (
toolpad-studio
andtoolpad-core
) to separate splitting the Toolpad documentation into Toolpad Studio and Toolpad Core, as part of [docs] Split Toolpad into Studio and Core toolpad#3250Rename "MUI Toolpad" => "Toolpad"