Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Fix createSpacing return type #41318

Merged

Conversation

matystroia
Copy link
Contributor

PR #23224 added the ability to pass string arguments to theme.spacing, but did not change the Spacing interface, which still expects the unary value argument to be a number rather than the number | string

@mui-bot
Copy link

mui-bot commented Feb 29, 2024

Netlify deploy preview

https://deploy-preview-41318--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f297dab

@zannager zannager added the package: system Specific to @mui/system label Feb 29, 2024
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great first contribution!

@siriwatknp siriwatknp enabled auto-merge (squash) March 1, 2024 09:14
@siriwatknp siriwatknp merged commit 2511261 into mui:master Mar 1, 2024
18 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants