-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joy-ui][docs] Add UI improvements to the side navigation demo #41461
Merged
Commits on Mar 12, 2024
-
[joy-ui][docs] Optimize side navigation's relative contrast
The right sidebar has been updated to the ‘solid’ variant for improved interaction with IconButtons. It is now darker than the left sidebar, creating better relative contrast and lifting the left sidebar higher on the screen. Additionally, the styles are consistent whether in light or dark mode, addressing previous issue where the right sidebar appeared higher/lower based on the color scheme.
Configuration menu - View commit details
-
Copy full SHA for e41b24f - Browse repository at this point
Copy the full SHA e41b24fView commit details -
[joy-ui][docs] Fix Side navigation IconButton interaction issues.
1. **Avatar Visibility Improvement:** Previously, when the avatar contained a picture, the interaction was hidden. But now, it's fixed, You’ll see the hover, active, and all the props that we expect from a button. (tested on dark/light mode). 2. **Plus Icon Enhancement:** The plus icon shape used to look distorted. We’ve standardized the size for all icon buttons in the right sidebar. Additionally, we’ve ensured that they are neatly aligned using align-items.
Configuration menu - View commit details
-
Copy full SHA for 3673658 - Browse repository at this point
Copy the full SHA 3673658View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75dc7b4 - Browse repository at this point
Copy the full SHA 75dc7b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2aadd7 - Browse repository at this point
Copy the full SHA a2aadd7View commit details -
Make color success global to all badges withing the right sidebar
If there are several users online, it’s a good idea to use the color ‘success’ for all badges with `color="success"`. ps: the badgecolorsuccess import was removed, it isn't needed.
Configuration menu - View commit details
-
Copy full SHA for a14ea41 - Browse repository at this point
Copy the full SHA a14ea41View commit details -
Configuration menu - View commit details
-
Copy full SHA for f99e023 - Browse repository at this point
Copy the full SHA f99e023View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11d8026 - Browse repository at this point
Copy the full SHA 11d8026View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c1e74d - Browse repository at this point
Copy the full SHA 3c1e74dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc98476 - Browse repository at this point
Copy the full SHA cc98476View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a1dc6a - Browse repository at this point
Copy the full SHA 6a1dc6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c09770 - Browse repository at this point
Copy the full SHA 3c09770View commit details -
Configuration menu - View commit details
-
Copy full SHA for b14f711 - Browse repository at this point
Copy the full SHA b14f711View commit details -
Configuration menu - View commit details
-
Copy full SHA for 931e91d - Browse repository at this point
Copy the full SHA 931e91dView commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2f4468a - Browse repository at this point
Copy the full SHA 2f4468aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.