Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Copy translations.json to @mui/docs build folder #41472

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[code-infra] Copy translations.json to @mui/docs build folder #41472

merged 1 commit into from
Mar 13, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 13, 2024 •
edited
Loading

Copy translation files into the build folder. These are unfortunately not automatically copied to the build folder as our build system only simply transpiles a set of source files and doesn't resolve imports correctly as a real bundler would.

Fixes #41246 (comment)

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Mar 13, 2024
@mui-bot
Copy link

mui-bot commented Mar 13, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41472--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 675a013

@Janpot Janpot marked this pull request as ready for review March 13, 2024 11:59
@Janpot Janpot requested a review from michaldudak March 13, 2024 11:59
michaldudak
michaldudak approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well!

@Janpot Janpot merged commit d26d07e into mui:master Mar 13, 2024
19 of 20 checks passed
@Janpot Janpot deleted the copy-translations branch March 13, 2024 14:32
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
This was referenced May 21, 2024
Open
Open
@RTHariSankar RTHariSankar mentioned this pull request May 21, 2024
Open
@GitLukeW GitLukeW mentioned this pull request May 21, 2024
Open
@amylank22 amylank22 mentioned this pull request May 21, 2024
Open
@aqibawan12 aqibawan12 mentioned this pull request May 21, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request May 21, 2024
Open
@Crushoverride007 Crushoverride007 mentioned this pull request May 21, 2024
Open
This was referenced Jun 5, 2024
Open
Open
@FaroukAmr FaroukAmr mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
@Poseidon-G Poseidon-G mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Closed
Closed
Closed
This was referenced Jun 6, 2024
Open
Open
@sufi0900 sufi0900 mentioned this pull request Jun 6, 2024
Open
This was referenced Jun 6, 2024
Open
Open
@mattboddy47 mattboddy47 mentioned this pull request Jun 6, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Open
This was referenced Jul 16, 2024
Open
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Jul 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @mui-bot @michaldudak