Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pigment-css][docs] Add media query guide #41473

Merged
merged 2 commits into from
Mar 18, 2024
Merged

[pigment-css][docs] Add media query guide #41473

merged 2 commits into from
Mar 18, 2024

Conversation

siriwatknp
Copy link
Member

closes #41420

@mui-bot
Copy link

mui-bot commented Mar 13, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41473--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a7d51d3

@danilo-leal danilo-leal changed the title [docs] Add media query guide to Pigment CSS [pigment-css][docs] Add media query guide Mar 13, 2024
@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: pigment-css Specific to @pigment-css/* labels Mar 13, 2024
danilo-leal
danilo-leal reviewed Mar 13, 2024
View reviewed changes
packages/pigment-css-react/README.md Outdated Show resolved Hide resolved
packages/pigment-css-react/README.md Outdated Show resolved Hide resolved
@siriwatknp @danilo-leal
Apply suggestions from code review
a7d51d3 
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
danilo-leal
danilo-leal approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@siriwatknp siriwatknp merged commit 8613386 into mui:master Mar 18, 2024
17 of 18 checks passed
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
@NOUIY NOUIY mentioned this pull request May 21, 2024
Open
This was referenced Jun 5, 2024
Open
Open
@FaroukAmr FaroukAmr mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Jun 5, 2024
Open
Open
@Poseidon-G Poseidon-G mentioned this pull request Jun 5, 2024
Open
This was referenced Jun 5, 2024
Closed
Closed
Open
This was referenced Jun 6, 2024
Open
Open
@sufi0900 sufi0900 mentioned this pull request Jun 6, 2024
Open
This was referenced Jun 6, 2024
Open
Open
@mattboddy47 mattboddy47 mentioned this pull request Jun 6, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Open
This was referenced Jul 16, 2024
Open
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Jul 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brijeshb42 brijeshb42 brijeshb42 left review comments

@danilo-leal danilo-leal danilo-leal approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: pigment-css Specific to @pigment-css/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pigment-css][docs] Docs suggestions
4 participants
@siriwatknp @mui-bot @brijeshb42 @danilo-leal