-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Use interface instead of type for props #41500
Conversation
Netlify deploy previewhttps://deploy-preview-41500--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into it. I suppose there is no straightforward way to add a test for this, right?
I guess there is but it would require some amount of effort. The idea is to use the build and run |
Yep, that doesn't fall under what I meant with "straightforward" 😄 |
fixes #40427
Material UI Popper
build before:
PopperProps
usage is replaced by its value with React.ElementType<...>build after:
PopperProps
is used, no usage of React.ElementType<...>.Base UI Popup
Before:
After: