-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigment-css][nextjs-plugin] Follow-up to #41494 #41502
Merged
brijeshb42
merged 2 commits into
mui:master
from
brijeshb42:pigment/next-resolve-followup
Mar 15, 2024
Merged
[pigment-css][nextjs-plugin] Follow-up to #41494 #41502
brijeshb42
merged 2 commits into
mui:master
from
brijeshb42:pigment/next-resolve-followup
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41502--material-ui.netlify.app/ Bundle size report |
brijeshb42
changed the title
[pigment-css][nextjs-plugin] Follow to #41494
[pigment-css][nextjs-plugin] Follow-up to #41494
Mar 15, 2024
brijeshb42
force-pushed
the
pigment/next-resolve-followup
branch
from
March 15, 2024 08:01
c3f6d9a
to
fd3298f
Compare
Resolve React and other related libraries to the actual ones in node_modules instead of Next.js' own version of React that will also include RSC related code that is not actually needed during WyW eval.
brijeshb42
force-pushed
the
pigment/next-resolve-followup
branch
from
March 15, 2024 08:02
fd3298f
to
b0f46fd
Compare
siriwatknp
reviewed
Mar 15, 2024
siriwatknp
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com> Signed-off-by: Brijesh Bittu <brijeshb42@gmail.com>
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 6, 2024
This was referenced Jun 6, 2024
This was referenced Jun 15, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve React and other related libraries to the actual ones in node_modules instead of Next.js' own version of React that will also include RSC related code that is not actually needed during WyW eval.
It also fixes the next.js demo app which broke after merging #41494