-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][docs] Fix landing page template's h1 size #41543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
design
This is about UI or UX design, please involve a designer
labels
Mar 18, 2024
Netlify deploy previewhttps://deploy-preview-41543--material-ui.netlify.app/ Bundle size report |
danilo-leal
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Glad we fixed this — left a couple of small remarks. (Also, you can cut the component="h1"
prop given the variant is the same as the tag we want this component to render as)
docs/data/material/getting-started/templates/landing-page/components/Hero.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/landing-page/components/Hero.js
Outdated
Show resolved
Hide resolved
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 6, 2024
This was referenced Jun 6, 2024
This was referenced Jun 15, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
This is about UI or UX design, please involve a designer
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
clamp()
to theh1
element in the landing page template to fix the massive layout shift on mobile when switching themes.https://deploy-preview-41543--material-ui.netlify.app/material-ui/getting-started/templates/landing-page/