-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][slider] Move palette styles to the bottom #41676
Conversation
Netlify deploy previewhttps://deploy-preview-41676--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
@siriwatknp could we check what's the root cause here? It feels like its important that we have full clarity on how our code behaves. I would say this in general, I think we should pursue all our confusions, at least it's incredibly hard for me to let go. But here, since we go after backward compatibility, it feels core to what we do. At minimum, I belive we need a GitHub issue to figure this out before releasing v6. |
I agree. It's hard for me to let go too but I don't have resource to get into this right now. I will create an issue for this. |
Issue: https://mui.com/material-ui/, see #41201 (comment)
I don't have time to dig down to the root cause at the moment. This is a quick fix to get rid of the styles generation error.
After: https://deploy-preview-41676--material-ui.netlify.app/material-ui/