Refractored css into js for raised-buttons #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mmrtnz
commented
Mar 10, 2015
mmrtnz
commented
- Added an overlay div to handle hovering.
- Modified Ripple opacity from 0.1 to 0.16 in order to better reflect current style.
- Modified flat-button and raised-button ("buttons") creation
- The "Choose An Image" and "GitHub" buttons manually created a label element to pass it in as a child of a button. They used button global classNames that have been moved into js.
- Buttons can now be created with both a label prop and children and will be styled appropriately.
- Darkened colors are close but not identical to their Less function equivalents.
…tered some rendering code for flat and raised buttons
… to get closer to original ripple styles.
mmrtnz
added a commit
that referenced
this pull request
Mar 11, 2015
Refractored css into js for raised-buttons
mmrtnz
added a commit
to mmrtnz/material-ui
that referenced
this pull request
Mar 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.