Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added inner style to paper to admit inline styling #418

Merged
merged 1 commit into from
Mar 11, 2015
Merged

added inner style to paper to admit inline styling #418

merged 1 commit into from
Mar 11, 2015

Conversation

bytesandwich
Copy link

Does this make sense as a way of styling the inner container in Paper if I'm using inline styles e.g.

<Paper
  style={{width:'100%', height:'100%'}}
  innerStyle={{width:'100%', height:'100%'}}>

@hai-cea
Copy link
Member

hai-cea commented Mar 11, 2015

Thanks @jackphel - I think this makes total sense. We're actually going to be doing this in the css-in-js branch.

Hope to be finished with that soon.

@mmrtnz
Copy link
Contributor

mmrtnz commented Mar 11, 2015

Yes that would be correct! We've been working on refactoring our css into javascript which includes the use of inline-styles. For large inline-styles I would recommend storing them in functions like so:

_paperStyle: function() {
    width: '100%',
    height: '100%',
},

// Somewhere in your render function
<Paper style={this._paperStyle()}>

mmrtnz added a commit that referenced this pull request Mar 11, 2015
@mmrtnz mmrtnz merged commit 6f708fc into mui:master Mar 11, 2015
brianfeister pushed a commit to brianfeister/material-ui that referenced this pull request May 1, 2017
fix the "collectCoverageFrom" config of jest
@zannager zannager added component: Paper This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Paper This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants