-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Dialog] Prevent onClick on the root element from being overwritten (@ryanburr) #41914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overwritten (#41881) Signed-off-by: Ryan Burr <ryan.burr2@gmail.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
github-actions
bot
added
bug 🐛
Something doesn't work
cherry-pick
The PR was cherry-picked from the next branch
component: dialog
This is the name of the generic UI component, not the React module!
needs cherry-pick
The PR should be cherry-picked to master after merge
package: material-ui
Specific to @mui/material
labels
Apr 15, 2024
ZeeshanTamboli
removed
the
needs cherry-pick
The PR should be cherry-picked to master after merge
label
Apr 15, 2024
Netlify deploy previewhttps://deploy-preview-41914--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
ZeeshanTamboli
approved these changes
Apr 15, 2024
This was referenced May 22, 2024
This was referenced May 22, 2024
This was referenced May 22, 2024
This was referenced Jun 20, 2024
Merged
This was referenced Jun 23, 2024
This was referenced Jun 25, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
cherry-pick
The PR was cherry-picked from the next branch
component: dialog
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #41881