-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] List Tree View features on the Pricing page #42328
[website] List Tree View features on the Pricing page #42328
Conversation
@@ -452,8 +454,8 @@ const rowHeaders: Record<string, React.ReactNode> = { | |||
'data-grid/column-autosizing': ( | |||
<ColumnHead label="Column autosizing" href="/x/react-data-grid/column-dimensions/#autosizing" /> | |||
), | |||
'data-grid/column-reorder': ( | |||
<ColumnHead label="Column reorder" href="/x/react-data-grid/column-ordering/" /> | |||
'data-grid/column-reordering': ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have "Row reordering" below
Netlify deploy previewhttps://deploy-preview-42328--material-ui.netlify.app/ @material-ui/core: parsed: +Infinity% , gzip: +Infinity% Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a doc for the Simple Tree View and a doc to the Rich Tree View. To which pages / doc sections should I link in the Pricing table?
This could be asign that the docs organization should be inverted. Group per feature, before per component type 🤔
'tree-view/item-virtualization': <ColumnHead label="Item virtualization" />, | ||
'tree-view/item-reordering': <ColumnHead label="Item reordering" />, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be simple enough, feels almost clearer
'tree-view/item-virtualization': <ColumnHead label="Item virtualization" />, | |
'tree-view/item-reordering': <ColumnHead label="Item reordering" />, | |
'tree-view/item-virtualization': <ColumnHead label="Virtualization" />, | |
'tree-view/item-reordering': <ColumnHead label="Reordering" />, |
), | ||
'tree-view/multi-item-selection': ( | ||
<ColumnHead | ||
label="Multi item selection" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe clearer
label="Multi item selection" | |
label="Multi selection" |
@@ -601,6 +603,33 @@ const rowHeaders: Record<string, React.ReactNode> = { | |||
'charts/filter-interaction': <ColumnHead label="Row filtering" />, | |||
'charts/selection-interaction': <ColumnHead label="Range selection" />, | |||
'tree-view/tree-view': <ColumnHead label="Tree View" href="/x/react-tree-view/" />, | |||
'tree-view/item-selection': ( | |||
<ColumnHead label="Item selection" href="/x/react-tree-view/rich-tree-view/selection/" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe clearer
<ColumnHead label="Item selection" href="/x/react-tree-view/rich-tree-view/selection/" /> | |
<ColumnHead label="Single selection" href="/x/react-tree-view/rich-tree-view/selection/" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the grid equivalent feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my view, the data grid, needs to differentiate between row and cell selection, but the pricing page stills uses the same terminology as in the docs pages.
I would see the pricing page always matching with what the docs use, it's one less thing to have to think about. So I think "Should we update the grid equivalent feature?" is truly about asking:
should stay like this, or become:
I personally feel that it works well as it's today in the docs.
Both component do not always behave the same. |
@flaviendelangle Ah right, so Overall, I would propose to be consistent, we have a similar problem with composition for charts, Material UI vs. Base UI + Pigment CSS. Maybe it could be like this:
For example in https://mui.com/x/react-charts/bars/. I imagine we will create docs for how to recreate the Now, the downside of showing the higher-level API first, and the lower-level API second is that people might stop at the higher-level API, but turned-off and not look further enough to find the lower-level API. But I don't know, the opposite failure mode feels as bad. It relates a bit to a discussion we had with @colmtuite & @danilo-leal during React Conf about either Material UI v7 should drop the |
It is not We could probably heavily re-work the |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
Follow up on #42100
I did some cleaning in the code.
I struggle to understand some choices in the code of this page. Why do we have 5 listings (one for the JSX Element of the name, of for each plan and yet a 5th one to actually render the row)? This make the action of adding a new item super tedious...
Preview: https://deploy-preview-42328--material-ui.netlify.app/pricing/
Problem