Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix hero spacing changes applying at the wrong breakpoint #42341

Merged
merged 3 commits into from
May 23, 2024

Conversation

KenanYusuf
Copy link
Contributor

Looks like the min-height and padding-top were supposed to be applied at the md breakpoint instead of sm.

Before After
mui com_ localhost_3000_

@KenanYusuf KenanYusuf added the website Pages that are not documentation-related, marketing-focused. label May 22, 2024
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch — appreciate it! 🤙

@KenanYusuf KenanYusuf added the needs cherry-pick The PR should be cherry-picked to master after merge label May 23, 2024
@mui-bot
Copy link

mui-bot commented May 23, 2024

Netlify deploy preview

https://deploy-preview-42341--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 066cd6d

@KenanYusuf KenanYusuf merged commit c311f80 into mui:next May 23, 2024
19 checks passed
@KenanYusuf KenanYusuf deleted the website-hero-spacing branch May 23, 2024 11:58
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants