Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Revert deprecation warnings for *Components and *Props for v6 #42466

Merged

Conversation

lhilgert9
Copy link
Contributor

Reverts the @deprecated warnings added as part of #41281 as described in #41281 (comment).

@lhilgert9 lhilgert9 changed the title [material-ui] Revert deprecation warnings for *Components and *Props for v7 [material-ui] Revert deprecation warnings for *Components and *Props for v6 May 31, 2024
@mui-bot
Copy link

mui-bot commented May 31, 2024

@zannager zannager added the package: material-ui Specific to @mui/material label Jun 3, 2024
@zannager zannager requested a review from DiegoAndai June 3, 2024 14:50
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lhilgert9, thanks for working on this, and sorry for the late review.

May I ask you a couple of things:

  • Let's keep the deprecations on the TextField component, as this solves a common confusion between inputProps and InputProps
  • May I ask you to remove these deprecations from the migrating from deprecated APIs guide as well
  • May I ask you to use this PR to also remove the corresponding deprecations from the deprecations-all script. No need to remove the deprecations, just remove them from the deprecations-all codemod.

@lhilgert9
Copy link
Contributor Author

@DiegoAndai Sorry for the long processing time. I have implemented the requested changes. However, some of the deprecations cannot be removed from the deprecations-all script, because in these the deprecations for *Component / *Props and components / componentProps are executed together. These are:

  • Autocomplete
  • Backdrop
  • ListItem
  • StepLabel

What should I do with them? Either we delete the code from the respective files or split the files into the respective deprecations.

@DiegoAndai
Copy link
Member

Either we delete the code from the respective files or split the files into the respective deprecations.

Lets delete the code

@lhilgert9
Copy link
Contributor Author

@DiegoAndai Code deletion is done.
ListItem had no codemod, just the the removed deprecated guide and the deprecations itself.

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lhilgert9, sorry for the late review.

I only have one question left 😊

Signed-off-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
Signed-off-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
Signed-off-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
Signed-off-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
@lhilgert9
Copy link
Contributor Author

@DiegoAndai Done🚀

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhilgert9!

@DiegoAndai DiegoAndai merged commit 0eb2ba1 into mui:next Jul 10, 2024
22 checks passed
@lhilgert9 lhilgert9 deleted the revert-components&props-deprecation-warnings branch July 11, 2024 10:42
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
DiegoAndai added a commit to DiegoAndai/material-ui that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants