-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Revert deprecation warnings for *Components
and *Props
for v6
#42466
[material-ui] Revert deprecation warnings for *Components
and *Props
for v6
#42466
Conversation
*Components
and *Props
for v7*Components
and *Props
for v6
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lhilgert9, thanks for working on this, and sorry for the late review.
May I ask you a couple of things:
- Let's keep the deprecations on the
TextField
component, as this solves a common confusion betweeninputProps
andInputProps
- May I ask you to remove these deprecations from the migrating from deprecated APIs guide as well
- May I ask you to use this PR to also remove the corresponding deprecations from the deprecations-all script. No need to remove the deprecations, just remove them from the
deprecations-all
codemod.
…rops-deprecation-warnings
@DiegoAndai Sorry for the long processing time. I have implemented the requested changes. However, some of the deprecations cannot be removed from the deprecations-all script, because in these the deprecations for *Component / *Props and components / componentProps are executed together. These are:
What should I do with them? Either we delete the code from the respective files or split the files into the respective deprecations. |
Lets delete the code |
@DiegoAndai Code deletion is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lhilgert9, sorry for the late review.
I only have one question left 😊
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
Signed-off-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
Signed-off-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
Signed-off-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
@DiegoAndai Done🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lhilgert9!
Reverts the
@deprecated
warnings added as part of #41281 as described in #41281 (comment).