Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Add support donation button #42499

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 2, 2024

@oliviertassinari oliviertassinari added the scope: infra Org infrastructure work going on behind the scenes label Jun 2, 2024
@mui-bot
Copy link

mui-bot commented Jun 2, 2024

Netlify deploy preview

https://deploy-preview-42499--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 15a7c84

@zannager zannager requested a review from DiegoAndai June 3, 2024 15:02
@DiegoAndai
Copy link
Member

@oliviertassinari this would add the line to all issues, right? I'm not a fan of that. I think we should keep the issues clean and add the donation callouts in other places. What do you think?

@oliviertassinari
Copy link
Member Author

this would add the line to all issues, right?

@DiegoAndai it didn't in badges/shields#10221

@DiegoAndai
Copy link
Member

Oh ok, then I'm ok with it 👍🏼

I wonder what @samuelsycamore thinks

Co-authored-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jun 6, 2024

Ok, so potentially, we could merge this. It feels like it something that should be removed at the point where we find a better monetization model than commercial licensed code. But until then, maybe it makes sense? Like it communicates to developer that we are trying to make it work as much as possible with open source.

The only cons I can think of is that it's unlikely to make meaningful differences, so would be noise for future issue creators, it's not if you donate $10 we will fix your issue.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me 👍

@oliviertassinari oliviertassinari merged commit 2ef685d into mui:next Jun 23, 2024
19 checks passed
@oliviertassinari oliviertassinari mentioned this pull request Jun 23, 2024
@oliviertassinari oliviertassinari deleted the donation-footer branch June 23, 2024 20:50
oliviertassinari added a commit to mui/base-ui that referenced this pull request Jun 23, 2024
oliviertassinari added a commit to mui/pigment-css that referenced this pull request Jun 23, 2024
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jun 23, 2024

Applied to Base UI and Pigment CSS. I didn't do it on Toolpad and MUI X since those will have more obvious commercial parts. We could still do it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants