-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Add support donation button #42499
Conversation
382bb25
to
d19043c
Compare
Netlify deploy previewhttps://deploy-preview-42499--material-ui.netlify.app/ Bundle size report |
@oliviertassinari this would add the line to all issues, right? I'm not a fan of that. I think we should keep the issues clean and add the donation callouts in other places. What do you think? |
@DiegoAndai it didn't in badges/shields#10221 |
Oh ok, then I'm ok with it 👍🏼 I wonder what @samuelsycamore thinks |
Co-authored-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Ok, so potentially, we could merge this. It feels like it something that should be removed at the point where we find a better monetization model than commercial licensed code. But until then, maybe it makes sense? Like it communicates to developer that we are trying to make it work as much as possible with open source. The only cons I can think of is that it's unlikely to make meaningful differences, so would be noise for future issue creators, it's not if you donate $10 we will fix your issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me 👍
Applied to Base UI and Pigment CSS. I didn't do it on Toolpad and MUI X since those will have more obvious commercial parts. We could still do it though. |
I saw this from https://github.com/badges/shields/issues/new?assignees=&labels=service-badge&projects=&template=3_Badge_request.yml
I wonder if this would make sense in our context.
Preview: https://github.com/oliviertassinari/material-ui/blob/donation-footer/.github/ISSUE_TEMPLATE/1.bug.yml