Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Alert] Add ability to override slot props #42787

Merged
merged 4 commits into from
Jun 30, 2024
Merged

[material-ui][Alert] Add ability to override slot props #42787

merged 4 commits into from
Jun 30, 2024

Conversation

alexey-kozlenkov
Copy link
Contributor

@alexey-kozlenkov alexey-kozlenkov commented Jun 29, 2024 •
edited by ZeeshanTamboli
Loading

Closes #42601

@mui-bot
Copy link

mui-bot commented Jun 29, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42787--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9453ade

@alexey-kozlenkov alexey-kozlenkov changed the title [material-ui][Alert] Add option to override slot props [material-ui][Alert] Add ability to override slot props Jun 29, 2024
@ZeeshanTamboli ZeeshanTamboli added typescript package: material-ui Specific to @mui/material component: alert This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Jun 30, 2024
@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge label Jun 30, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexey-kozlenkov Thanks for working on it. Looks good. I added a TypeScript module augmentation test.

@ZeeshanTamboli ZeeshanTamboli merged commit 5a2327f into mui:next Jun 30, 2024
20 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 30, 2024
@alexey-kozlenkov @ZeeshanTamboli @web-flow
[material-ui][Alert] Add ability to override slot props (#42787)
83544dd 
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 30, 2024
Merged
@alexey-kozlenkov alexey-kozlenkov deleted the feat/alert-override-slot-props branch July 1, 2024 11:39
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@alexey-kozlenkov @ZeeshanTamboli @joserodolfofreitas
[material-ui][Alert] Add ability to override slot props (mui#42787)
f94a8c6 
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
component: alert This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][Alert] TS error when using slotProps with customised component
3 participants
@alexey-kozlenkov @mui-bot @ZeeshanTamboli