Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][docs] Audit and copyedit the v6 migration doc #43073

Merged
merged 37 commits into from
Aug 16, 2024
Merged

[material-ui][docs] Audit and copyedit the v6 migration doc #43073

merged 37 commits into from
Aug 16, 2024

Conversation

samuelsycamore
Copy link
Contributor

@samuelsycamore samuelsycamore commented Jul 25, 2024 •
edited
Loading

Copyedits on the v6 migration doc. I'll review the other v6 migration docs in separate PRs.

@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material v6.x migration labels Jul 25, 2024
@samuelsycamore samuelsycamore self-assigned this Jul 25, 2024
@mui-bot
Copy link

mui-bot commented Jul 25, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6053e7c

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 29, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 29, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 30, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 7, 2024
@samuelsycamore samuelsycamore marked this pull request as ready for review August 7, 2024 22:53
@samuelsycamore samuelsycamore changed the title [material-ui][docs] Audit and copyedit the v6 migration pages [material-ui][docs] Audit and copyedit the v6 migration doc Aug 7, 2024
@DiegoAndai DiegoAndai self-assigned this Aug 13, 2024
@DiegoAndai
Copy link
Member

@alelthomas ready for review 😊

This was referenced Aug 14, 2024
Merged
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 15, 2024
alelthomas and others added 3 commits August 15, 2024 21:52
@alelthomas
remove the for readability
d538e5f 
Signed-off-by: Ale <93217218+alelthomas@users.noreply.github.com>
@alelthomas @siriwatknp
explain spacing change with CSS gap property
bc287fc 
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
Signed-off-by: Ale <93217218+alelthomas@users.noreply.github.com>
@alelthomas
minor improvements
171a071 
Signed-off-by: Ale <93217218+alelthomas@users.noreply.github.com>
alelthomas
alelthomas approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@alelthomas alelthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're all good to go 🚀 @siriwatknp

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 16, 2024
siriwatknp
siriwatknp approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@siriwatknp siriwatknp enabled auto-merge (squash) August 16, 2024 04:08
@siriwatknp siriwatknp merged commit 1758f62 into mui:next Aug 16, 2024
22 checks passed
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 17, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 18, 2024
Merged
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai left review comments

@aarongarciah aarongarciah aarongarciah left review comments

@alelthomas alelthomas alelthomas approved these changes

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@DiegoAndai DiegoAndai

@samuelsycamore samuelsycamore

Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material v6.x migration
Projects
Material UI
Status: Done
Milestone
Material UI: v6
Development

Successfully merging this pull request may close these issues.
6 participants
@samuelsycamore @mui-bot @DiegoAndai @aarongarciah @siriwatknp @alelthomas