-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Refine and unify custom template themes #43220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
design
This is about UI or UX design, please involve a designer
labels
Aug 7, 2024
Netlify deploy previewhttps://deploy-preview-43220--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 8, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 9, 2024
10 tasks
This reverts commit 46f5aa0.
aarongarciah
force-pushed
the
refine-custom-theme
branch
from
August 16, 2024 09:37
f9edd82
to
56ea32d
Compare
@zanivan I rebased on top of |
aarongarciah
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Note: I haven't reviewed every single file, but overall looks good.
9 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
This is about UI or UX design, please involve a designer
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to unify and standardize custom themes and its structure across all the templates.
The only difference is that in the Dashboard template, we'll have some extra files for X's components such as
DataGrid
,DatePicker
,TreeView
andCharts
.For the structure, I follow the same grouping as Material UI's docs, grouping custom components style by Inputs, DataDisplay, Feedback, Surfaces, Navigation, Layout, Utils:
👉 https://deploy-preview-43220--material-ui.netlify.app/material-ui/getting-started/templates/