Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][mui-system] Cherry-pick: Add support for version runtime checks (#43190) #43233

Merged
merged 4 commits into from
Aug 9, 2024
Merged

[material-ui][mui-system] Cherry-pick: Add support for version runtime checks (#43190) #43233

merged 4 commits into from
Aug 9, 2024

Conversation

DiegoAndai
Copy link
Member

Cherry-pick #43190 to master, so the version consts are available in v5 as well

@DiegoAndai DiegoAndai requested a review from mnajdova August 8, 2024 14:54
@DiegoAndai DiegoAndai self-assigned this Aug 8, 2024
@DiegoAndai DiegoAndai added package: system Specific to @mui/system package: material-ui Specific to @mui/material cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch labels Aug 8, 2024
@mui-bot
Copy link

mui-bot commented Aug 8, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43233--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ef33a9a

@DiegoAndai
Copy link
Member Author

DiegoAndai commented Aug 8, 2024 •
edited
Loading

Had to do 8ac5388 refactor to solve this error (avoid this pitfall as useReactVersion also imports from utils).

I'll create a PR to do this change in next as well. I wonder why it didn't fail in #43190

@DiegoAndai DiegoAndai mentioned this pull request Aug 8, 2024
Merged
mnajdova
mnajdova approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that it works in https://codesandbox.io/s/gifted-keller-t4h8hx

@mnajdova mnajdova merged commit 74ac40c into mui:master Aug 9, 2024
19 checks passed
@DiegoAndai DiegoAndai deleted the support-version-const branch August 9, 2024 16:23
@DiegoAndai DiegoAndai mentioned this pull request Aug 23, 2024
Merged
@mattboddy47 mattboddy47 mentioned this pull request Aug 30, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@DMPatod DMPatod mentioned this pull request Aug 30, 2024
Open
@FrancescoCoding FrancescoCoding mentioned this pull request Aug 30, 2024
Open
This was referenced Aug 30, 2024
Merged
Merged
This was referenced Aug 30, 2024
Closed
Merged
@mbreadmachine mbreadmachine mentioned this pull request Aug 30, 2024
Closed
This was referenced Aug 30, 2024
Closed
Closed
Merged
@nachodev-ui nachodev-ui mentioned this pull request Aug 30, 2024
Open
@amylank22 amylank22 mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
@sufi0900 sufi0900 mentioned this pull request Oct 3, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
This was referenced Oct 4, 2024
Closed
Closed
This was referenced Oct 5, 2024
Open
Open
This was referenced Oct 6, 2024
Open
Open
@sergivj sergivj mentioned this pull request Oct 26, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request Oct 26, 2024
Open
@tanyo76 tanyo76 mentioned this pull request Oct 27, 2024
Open
@mattboddy47 mattboddy47 mentioned this pull request Oct 28, 2024
Open
@q1blue q1blue mentioned this pull request Oct 29, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 31, 2024
Open
@RTHariSankar RTHariSankar mentioned this pull request Oct 31, 2024
Open
@sufi0900 sufi0900 mentioned this pull request Oct 31, 2024
Open
@aezazali1997 aezazali1997 mentioned this pull request Oct 31, 2024
Open
@PaolaQ-I PaolaQ-I mentioned this pull request Nov 1, 2024
Open
@mflorezmejia mflorezmejia mentioned this pull request Nov 1, 2024
Open
@CharlesGuerrero14 CharlesGuerrero14 mentioned this pull request Nov 2, 2024
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Nov 3, 2024
Open
This was referenced Nov 3, 2024
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Nov 5, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees

@DiegoAndai DiegoAndai

Labels
cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch package: material-ui Specific to @mui/material package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DiegoAndai @mui-bot @mnajdova