[core][material-ui] Prevent scrolling when restoring after FocusTrap #43301
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aarongarciah, @mnajdova, what's the status of moving @mui/base components to Material UI? Do you still want to accept PRs to @mui/base? |
|
The proposed change makes sense, although I'm pretty sure we will find developers who relied on the old behavior. I'm not really keen on introducing a prop to configure this. @aarongarciah, we could squeeze it into v6 as a breaking change (and possibly make it configurable in the future if there are complaints?) |
|
@michaldudak sadly, we won't be including further breaking changes to the upcoming v6 stable release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43299