Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Change React.ReactElement<any,any> type from any to unknown #43358

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 18, 2024

Part of: #42380

since no one has taken up the issue since last 3 months, i opened PR fixed it

@sai6855 sai6855 changed the title [material-ui] Change React.ReactElement type from any to unknown [material-ui] Change React.ReactElement<any,any> type from any to unknown Aug 18, 2024
@mui-bot
Copy link

mui-bot commented Aug 18, 2024

Netlify deploy preview

https://deploy-preview-43358--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4a7acea

@sai6855 sai6855 added typescript React 19 support PRs required to support React 19 labels Aug 18, 2024
@sai6855 sai6855 requested a review from DiegoAndai August 18, 2024 10:35
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this @sai6855!

I could find other instances of ReactElement<any> still present. No need to cover them in this PR, but

  • If we don't cover all cases, we should remove the "close" keyword in the description.
  • If you wish to close the issue in this PR, then we should cover all cases. If you do, then skip the base/ and joy/.

Whatever option you prefer, let me know 😊

@sai6855
Copy link
Contributor Author

sai6855 commented Aug 21, 2024

I could find other instances of ReactElement<any> still present.

Ah okay, I've changed closes to part of. Regarding remaining instances, I'll open new PR as it will be easier for you to review

@sai6855
Copy link
Contributor Author

sai6855 commented Aug 22, 2024

@DiegoAndai opened follow up PR for some of left over instances #43402

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sai6855 😊

@DiegoAndai DiegoAndai merged commit 129a3ef into mui:master Aug 26, 2024
19 checks passed
aarongarciah pushed a commit to aarongarciah/material-ui that referenced this pull request Aug 26, 2024
@oliviertassinari oliviertassinari removed the React 19 support PRs required to support React 19 label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants