Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][ListItem] Remove unnecessary TypeScript test #43359

Merged
merged 2 commits into from
Aug 19, 2024
Merged

[material-ui][ListItem] Remove unnecessary TypeScript test #43359

merged 2 commits into from
Aug 19, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 18, 2024 •
edited
Loading

Since button prop is removed from ListItem, i felt this test is unnecessary

@sai6855 sai6855 added component: list This is the name of the generic UI component, not the React module! typescript package: material-ui Specific to @mui/material labels Aug 18, 2024
@sai6855 sai6855 requested a review from ZeeshanTamboli August 18, 2024 10:50
@mui-bot
Copy link

mui-bot commented Aug 18, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43359--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5e37850

ZeeshanTamboli
ZeeshanTamboli approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][ListItem] Remove unnecessary ts test [material-ui][ListItem] Remove unnecessary TypeScript test Aug 19, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit f7237d8 into mui:next Aug 19, 2024
19 checks passed
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 17, 2024
Open
@shagg0r shagg0r mentioned this pull request Sep 18, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 18, 2024
Merged
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Sep 22, 2024
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @ZeeshanTamboli