[docs][material-ui][system] Edit "How to use components selector API" section to add about direct import #43377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAluI
changed the title
Netlify deploy previewBundle size report |
zannager
added
docs
ZeeshanTamboli
added
package: styled-engine
There was a problem hiding this comment.
@IAluI It looks good. But can you open a new PR and point it to master instead? Version 6 also supports Emotion JS. You can tag me once you open a PR and close this one.
github-actions
bot
added
the
PR: out-of-date
- add @mui/material to @emotion/babel-plugin config - add note about @emotion/babel-plugin and babel-plugin-direct-import order Signed-off-by: Ilya Molostov <29124424+IAluI@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
|
@ZeeshanTamboli I noticed that MUI changed the default branch. I made the appropriate changes to my fork. Still need a new PR? |
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
@IAluI Looks good! I've linked proof that it works here: https://stackblitz.com/edit/vitejs-vite-t82o8s?file=vite.config.ts,src%2FApp.tsx&terminal=dev (also added in the description). I made a few tweaks, which you can see in the commits. Thanks for the pull request!
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof that it works: https://stackblitz.com/edit/vitejs-vite-t82o8s?file=vite.config.ts,src%2FApp.tsx&terminal=dev