[core] Fix typescript-next CI workflow #43394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43394--material-ui.netlify.app/ Bundle size report |
aarongarciah
commented
Aug 21, 2024
Janpot
approved these changes
Aug 21, 2024
This reverts commit 3050eec.
Janpot
reviewed
Aug 21, 2024
.circleci/config.yml
Outdated
| @@ -352,13 +352,13 @@ jobs: | |||
| resource_class: 'medium+' | |||
| steps: | |||
| - checkout | |||
| - install_js | |||
| - run: | |||
| name: Resolve typescript version | |||
| command: | | |||
| pnpm add typescript@next -d -w | |||
There was a problem hiding this comment.
You could try with the following command. (Not sure it will work)
Suggested change
| pnpm add typescript@next -d -w | |
| pnpm update -r typescript@next |
There was a problem hiding this comment.
It "works": https://app.circleci.com/pipelines/github/mui/material-ui/136906/workflows/efb61b97-5715-455c-915f-a008c66cd81d/jobs/738078. It fails silently because this job is meant to fail silently.
The previous command also resulted in the same error: https://app.circleci.com/pipelines/github/mui/material-ui/136902/workflows/b9c1cbb1-625e-4e3d-a68b-4da986bd0108/jobs/738050?invite=true#step-107-198
Looks like the docs:typescript command is the one failing, but probably something to look into another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
typescript-nextCircleCI workflow is failing due to a mismatch of the pnpm version installed vs the one defined in package.json engines. Example failure: https://app.circleci.com/pipelines/github/mui/material-ui/136842/workflows/2ee9d991-0807-4242-b5ae-f8911336ccb7/jobs/738034?invite=true#step-102-6To solve the issue, we need to run corepack before pnpm gets used. Also modifying the typescript install script so we update all packages and not only the root package.json