-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][docs] Add TemplateFrame to templates #43406
Conversation
Netlify deploy previewhttps://deploy-preview-43406--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aarongarciah what browser are you using? Tested on chrome here and couldn't reproduce it |
@zanivan I'm seeing it in at least Chrome, Safari and Arc (which is basically Chrome) in macOS with scroll bars always visible. Firefox seems to be the only one not doing the double scroll. |
I was recording a video to show that here it's not happening and a bugger bug showed up 😅 Do you have any idea on what might be happening? Screen.Recording.2024-08-23.at.12.45.23.mov |
@zanivan I need to look deeper but removing the footer fixes the double scroll bar and the issue you shared in the video (is the same issue). |
Just found the culprit: the hidden label in the email input in the footer, which is absolute positioned, is causing the overflow. Kapture.2024-08-23.at.18.46.32.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Left a couple of small comments for your consideration.
6a0c917
to
99e2ca2
Compare
Follow-up to #43396 based on #43396 (comment)
Fixes the layout and double scrollbars.
👉 https://deploy-preview-43406--material-ui.netlify.app/material-ui/getting-started/templates/